search

dbus2 / zbus-old

Rust D-Bus crate.
https://gitlab.freedesktop.org/dbus/zbus
Other
49 stars 13 forks source link

zbus 2.2.0 fails to build because some of its dependencies (zbus_names and zvariant) need rustc 1.60 or newer #7

Closed thsioutas closed 2 years ago

thsioutas commented 2 years ago

Hello! I use zbus in a custom library for which I do not use a static cargo.lock file. Due to zbus dependencies (i.e. zbus_names ^2) this fails for the current rustc version I use. As a workaround I used tilde requirements for zbus, zbus_names and zvariant in my cargo.toml file. However, I was wondering if this is the right solution or if a stricter version requirement is needed in zbus cargo.toml file. Thank you in advance!

zeenix commented 2 years ago

As a workaround I used tilde requirements for zbus, zbus_names and zvariant in my cargo.toml file. However, I was wondering if this is the right solution or if a stricter version requirement is needed in zbus cargo.toml file.

I'm not sure what other workarounds you can use but zbus declaring the MSRV won't help, you'll just get a better warning. Also I couldn't find a way (in stable Rust) to declare such a requirement. We did indeed recently added the MSRV check to our (gitlab) CI so at least we wont' be bumping the requirement by mistake in the future.

I'm sorry I couldn't be of more help.

zeenix commented 2 years ago

Also I couldn't find a way (in stable Rust) to declare such a requirement.

Oh I remembered incorrectly. We do now require a Rust version explicitly. I'm about to release 3.0 that'll have this feature.