dbus2 / zbus

Rust D-Bus crate.
Other
319 stars 70 forks source link

RFC: Drop vsock support #830

Open zeenix opened 1 month ago

zeenix commented 1 month ago

We added vsock support back a few years ago in anticipation of it being accepted in the D-Bus spec and reference implementation. However, this never happened and it's very unlikely to happen as the discussion has died out.

Moreover, I do not know if anyone is actually using it at all. Given that it's a maintenance burden and we've more work than developer/maintenance time available, I'm leaning towards removing this. The fact that we don't have any tests for this, means that we don't even know if this support actually works and when/if it breaks. We also sometimes have issues with it.

If you disagree, this is your chance to speak up.

zeenix commented 1 month ago

@elmarco ^

elmarco commented 1 month ago

I still wish some day a guest bus can be accessed from a host easily, or some guest services be on a VM host bus. Unfortunately, working on VM & desktop is not very popular.. Even ssh over vsock is very recent, thanks to Lennart systemd-ssh-proxy..

How bad is maintainance of the vsock feature?

zeenix commented 1 month ago

I still wish some day a guest bus can be accessed from a host easily, or some guest services be on a VM host bus.

I wish that too.

How bad is maintainance of the vsock feature?

Not a lot but given we've no testing for this in the CI, I don't even know if it actually works and wouldn't know if I (or anyone) breaks it.

zeenix commented 1 month ago

@elmarco btw you didn't answer to most important question: are you relying on the vsock support of zbus?

elmarco commented 1 month ago

@elmarco btw you didn't answer to most important question: are you relying on the vsock support of zbus?

not atm

zeenix commented 1 month ago

not atm

Thanks. So here is the deal: if you can add the CI to test vsock support, I'd be happy to keep it. Perhaps some small image you can boot in qemu and do a simple test?

elmarco commented 1 month ago

But there are some tests for vsock in CI already.

zeenix commented 1 month ago

But there are some tests for vsock in CI already.

Compile-only. It doesn't tell us the impl really works.