codepathreview
commented
9 years ago Great work getting all the required stories done along with a few optionals.
A few notes after checking out the code:
- Good to see you were able to format the timestamp cleanly (consider externalizing to utils class)
- Nice to see you used the
SwipeRefreshLayoutfor easy timeline refreshes - Good to see you refreshed the timeline after composing a new tweet
- Great job implementing the compose tweet feature as a dialog
- Good to see you added ActiveAndroid annotations to the models for offline usage
- Consider adding the character count for Compose Activity to limit to 140. See this event handler for more details.
- Nice effort on UI polish. Consider adding screen titles wherever necessary
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
Ready for review @codepathreview @codepath
Took advise and focused almost entirely on polish opposed to more bonus. Didn't have as much time as last week, with a bit more time I could finish all the bonus and more.