search

dbushell / grunt-svg2png

Grunt plugin to rasterize SVG to PNG images using PhantomJS
MIT License
76 stars 37 forks source link

Grunt 'rename' fix #23

Open samdbeckham opened 9 years ago

samdbeckham commented 9 years ago

There was an issue that cropped up when you used Grunt's rename function in the grunt config. Instead of saving the file to the desired location, it would create a folder at that location and save the icon within it, preceded by the CWD folder structure.

Reading that back, it makes very little sense (apologies, I'm a little hungover today), try it it out though and you'll see what I mean.

I've popped in some tests, updated the config and squashed the bug though.

samdbeckham commented 9 years ago

This might make the issue a little clearer.

Config: Result:

samdbeckham commented 9 years ago

Any thoughts on this @dbushell ?

theme commented 9 years ago

I stumbled on the same stone. Seems #9 introduced this. Maybe the default behavior is better not mutate file's src and dest attribute. Maybe an option 'preserve-path' for #9 's needs. Thanks @dbushell.