search

dbvideostriketeam / wubloader

MIT License
14 stars 6 forks source link

thrimbletrimmer: Validate chapter titles are ascii only #389

Closed ekimekim closed 4 months ago

ekimekim commented 4 months ago

We are not sure what characters are allowed in chapter titles. Emoji seem to be disallowed. It is unknown whether things like accents or smart quotes are allowed. To be conservative, we warn if there are any non-ascii characters in the chapter title.

Fixes https://github.com/dbvideostriketeam/wubloader/issues/325

ElementalAlchemist commented 4 months ago

This'll work. My only complaint (because I must nitpick this, apparently) is that you used a comma splice in the error message; a semicolon is preferred in that position (or break it up in some other way you prefer).