search

dbvideostriketeam / wubloader

MIT License
15 stars 8 forks source link

PRs should not push to ghcr.io without appropriate user permission (write) #473

Open MC42 opened 5 days ago

MC42 commented 5 days ago

RE: https://github.com/dbvideostriketeam/wubloader/pull/472#issuecomment-2466242926

It seems that regardless of the originating user, PRs are attempted to be run via CI including deploy steps. This is probably something that needs to be changed to avoid blocking other runners for more important deploys.

HubbeKing commented 5 days ago

to be clear - the CI doesn't do a deploy step, it does however try to push the image into the ghcr.io registry so that it can be pulled down elsewhere for testing. This is something that requires write access, so if there isn't write access the builds shouldn't try to push.

MC42 commented 5 days ago

I clearly don't fully grok the image deployment / test workflow, ty. I'll amend the issue title.