search

dbyoung720 / ImageGray

MMX/SSE/SSE2/SSE4/AVX/AVX2/AVX512 optimization
19 stars 9 forks source link

Copyright violation #1

Closed MHumm closed 2 years ago

MHumm commented 2 years ago

While I value what you try to schiebe, the inclusion of vcl.graphics.pas is a copyright violation. I doubt Embarcadero have you permission to publish this unit. Why ist it needed here?

dbyoung720 commented 2 years ago

Oh, let me see what to do.

When creating a large bitmap in memory, vcl.graphics.pas，it will be very time-consuming, so it has been modified.

MHumm commented 2 years ago

I know the issue of needing to copy a RTL/FMX/VCL file for modification... If you can't come up with anyithing else you could leave off the file and put instructions about that you need to copy and modify it and what needs to be added in your documentation... Another thing: if your modification is something more people would profit from, you might create an official feature request in Quality Portal: https://www.quality.embarcadero.com One fine day it might get included and spare you from needing to reapply your modification after each Delphi update.

Also be aware, that you need to reapply the modification for any new Delphi version!

dbyoung720 commented 2 years ago

OK. thank.

MHumm commented 2 years ago

Did you create a feature request in Quality Portal about the thing you'd like to get improved in vcl.graphics.pas? If yes, I'd like to know the report number so I can track it and possibly vote for it as well.

dbyoung720 commented 2 years ago

No. I just added a description in the readme.