search

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.42k stars 1.81k forks source link

silly filter outro on bar clickaway #1071

Open gordonwoodhull opened 8 years ago

gordonwoodhull commented 8 years ago

When you click an empty spot to get rid of the bar chart filter, there's a silly animation.

silly filter outro

It's cute, but no.

gordonwoodhull commented 8 years ago

Also on scatterplot.

Frozenlock commented 7 years ago

FWIW, I discovered this animation when grabbing the last minified version from here.

My old version (2.0.0-beta19) didn't have this.

gordonwoodhull commented 7 years ago

Thanks @Frozenlock, that's interesting. If anything I would have guessed it was introduced by the chart resizing stuff around beta 15.

Looks like it's transitioning to a zero-width brush instead of an empty brush. I don't think there should be any transition at all.

Frozenlock commented 7 years ago

I don't know if I should open a separate issue for this, but it's another weird animation issue that wasn't present in 2.0.0-beta19 but is in the most recent one:

Bars are now changing width (?!) and don't transition correctly when they need to disappear.

Old old-dc-js

New new-dc-js

gordonwoodhull commented 6 years ago

Hi @Frozenlock, sorry I missed this. If you're still seeing this and can file a separate issue, that will help a lot. Especially if you can create a demo fiddle.

I don't think I've seen seen this, and I don't see it in any of the standard examples. So it must mean that you've run into some combination of features that we don't test. (Keep in mind that the interaction of features is combinatorial!)

Frozenlock commented 6 years ago

@gordonwoodhull I haven't seen this since I upgraded to a newer version... but I also made a major overhaul in pretty much everything.

I'll pop in here if I ever encounter it again.