search

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.42k stars 1.81k forks source link

Fix the cumulative line chart. #1780

Closed kum-deepak closed 3 years ago

kum-deepak commented 3 years ago

It seems the cumulative line in the Pareto chart example is incorrect. Removing the sort in the fake group seems to fix it. Please review.

gordonwoodhull commented 3 years ago

The bars should be sorted from greatest to least, but they aren't taking the ordering from the group.

According to the screenshot, the example worked \ when I answered the question on SO, but already the fiddle does not work, so I don't know what happened.

This fixes it:

        .ordering(kv => -kv.value.value)
kum-deepak commented 3 years ago

Thanks, @gordonwoodhull! I have updated the code.

kum-deepak commented 3 years ago

The scatter-series example was showing the issue reported in #1772. Switching off mouseZoomable.

gordonwoodhull commented 3 years ago

Thanks @kum-deepak!