search

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.41k stars 1.81k forks source link

filter stacks example has invalid segment filtering #1787

Closed gordonwoodhull closed 3 years ago

gordonwoodhull commented 3 years ago

This example worked in dc@2 or dc@3, but currently clicking on a segment produces invalid selections with undefined in them:

image
kum-deepak commented 3 years ago

This example uses good knowledge of internal field names (not part of public API). Fixed to update the field names as per internal changes. Also needed was to use d3 v6 compact for the click event handler.

This example will undergo further changes to remove all deprecated calls.

gordonwoodhull commented 3 years ago

I tried to cherry-pick b0be203 to develop in order to close this out, but for some reason, adaptHandler is not exported even though it clearly has export in its definition. Not sure how to troubleshoot this since rollup is a black box.

It's not really a dc-v5 issue; it broke in dc@3 or @4.

kum-deepak commented 3 years ago

I will look into it. The entire commit is not needed here. Also, the adaptHandler may be exported from the file but may not be part of the library export. I will check and fix it.

kum-deepak commented 3 years ago

Please see #1796.