Closed kum-deepak closed 3 years ago
Before the final release of this library, I have the following additional targets:
cbox-menu
can be a good starting point.There is also a peculiar issue with the current .filter
call in the charts - it returns only the first item if there is more than one filter. This may confuse users - it is not necessary to tackle for this release though.
Great plan, thanks for explaining.
Yes, .filter()
returning one filter is sort of consistent because .filter()
also takes one filter and toggles it, and there is .filters()
too.
But it’s a weird interface for sure. Don’t forget how .filter()
can take an array where the first element is an array of filters, and each one is toggled!
My guess is that the need for more than one filter was not originally anticipated. But I haven’t looked back that far.
I tend to think it would be too confusing to keep the same method name and change the meaning, since there are so many examples out there. But I’m not dogmatic about it. The new version, with or without a new library name, is going to be a big change.
I agree with .filter
being used widely. I am not keeping it a priority, because it works and does not hamper any feature anywhere.
Merged commits other than the sample. I will be working on samples as separate PR(s).
These capabilities can allow a few interesting use cases:
Currently, these are not covered by test cases. I have modified the stocks sample to add options to save and restore.
Give it a spin when you have time.