search

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.41k stars 1.81k forks source link

Removed in d3v6, d3.mouse is used by `BubbleOverlay.debug` #1807

Closed kum-deepak closed 2 years ago

kum-deepak commented 3 years ago

This is not a commonly used option, so, it did not get detected earlier. It is possible to write a compat (new method d3.pointer). This needs to be applied to both dc v4 and v5.

kum-deepak commented 3 years ago

Need same change in dc-v5 branch.

gordonwoodhull commented 3 years ago

Pretty obscure!

According to 8a7de3c05 this debug feature is #52 and the idea is that you can use debug mode to get coordinates for your bubbles by hovering over the map. Bubble coordinates are specified one by one with BubbleOverlay.point() in pixel coordinates.

Screen Shot 2021-02-15 at 2 18 52 AM
gordonwoodhull commented 3 years ago

Interesting, looks like GitHub will now close an issue if a comment on a merged PR says "fixes #xxx" - this only used to work for commit messages.

Reopening for dc-v5; @kum-deepak, please apply the change at your convenience.

kum-deepak commented 3 years ago

Good to see you active again. It had started feeling very lonely :smile:

kum-deepak commented 2 years ago

Covered in #1847 for dc@v5.