dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.41k stars 1.81k forks source link

change event handlers to (event, datum) #1829

Open gordonwoodhull opened 3 years ago

gordonwoodhull commented 3 years ago

d3compat.eventHandler currently takes a function(datum, event) for trivial adaptation of old event handlers.

However, to reduce confusion and facilitate eventual removal of d3@5 compatibility, I think these should use the d3@6 signature.

Of course, we might not get to it until then; if not, this is documentation. It's something I noticed when working on #1824 when fixing tests to call consistently with the active version of d3. d3compat.callHandler takes a function(event, datum)