search

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.41k stars 1.81k forks source link

remove d3v5 compatibility layer #1846

Closed gordonwoodhull closed 2 years ago

gordonwoodhull commented 2 years ago

I'm glad that we took a conservative approach for adding d3v6 compatibility, with the compatibility layer.

However, having this extra level makes the code hard to read - I was just trying to read how data table sections work, and it's confusing having also to read compat/d3v6.js in order to understand it.

I think we should remove d3v5 compatibility for dc-v5.

kum-deepak commented 2 years ago

Thanks for raising this. I see one more reason: it will fundamentally fix https://github.com/dc-js/dc.js/issues/1822.

Modules support in the browsers is improving, and we should make dc to work as modules directly in the browser.

kum-deepak commented 2 years ago

closed by #1847