search

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js
Apache License 2.0
7.42k stars 1.81k forks source link

Remove d3v5 compat #1847

Closed kum-deepak closed 2 years ago

kum-deepak commented 2 years ago

Ref #1846

I am targeting d3@v7. I have checked the changelog between v6 and v7, it does not seem that dc is affected by any breaking changes. So, most likely dc will work with d3@v6 as well.

In the first commit, I have removed the nest helper and inlined relevant parts of the code.

kum-deepak commented 2 years ago

Next, I will work on d3.mouse. I realized it has been added to compact for dc@v4 (https://github.com/dc-js/dc.js/pull/1808 and https://github.com/dc-js/dc.js/issues/1807).

kum-deepak commented 2 years ago

Completed for now. @gordonwoodhull please check when you have time.

gordonwoodhull commented 2 years ago

Thanks @kum-deepak!

kum-deepak commented 2 years ago

Next, I will sync examples from the current develop branch and upgrade those to the latest syntax. After that, I will complete the migration guide.