update legend text y calculation #1855 & #1852

dc-js / dc.js

Multi-Dimensional charting built to work natively with crossfilter rendered with d3.js

Apache License 2.0

7.42k stars 1.81k forks source link

update legend text y calculation #1855 & #1852 #1856

Open Spacarar opened 2 years ago

Spacarar commented 2 years ago

After reading about these two issues, I was investigating the cause of this and found that on chrome the clientHeight was returning a much smaller value than getBoundingClientRect().height which was returning more consistent results across environments for me.

Please let me know if there are any issues with the code here so I can adjust accordingly.

kum-deepak commented 2 years ago

Many thanks! I have checked the code and it seems all fine. The CI testes Edge, Chrome, Firefox, and Safari, so, I guess we are good. This change request will get merged and released as part of the next release.

ufundo commented 1 month ago

Any chance of this fix being released for existing stable version?