dc-js / dc.leaflet.js

DC charts using Leaflet maps
Apache License 2.0
52 stars 24 forks source link

initialization of parameters that may have been set by createLeaflet #2

Closed gordonwoodhull closed 8 years ago

gordonwoodhull commented 9 years ago

Simon Johnson writes:

I haven't had a chance to try this particular version of the extension as I used my tweaked version as under time pressure. I did, however, use the same method of createLeaflet customization point. My feedback on this is that it needs to include the creation/adding of tiles and setting the zoom as these could already be set when the map has been created before DC is used.

gordonwoodhull commented 8 years ago

If I understand the feedback, it's to allow not setting tiles and zoom when those have already been initialized from the createLeaflet function.

It looks like this is already supported. Simply do not set the zoom, and set the tiles function to a no-op.