search

dc4eu / vc

European Wallet
BSD 2-Clause "Simplified" License
0 stars 2 forks source link

Change Request regarding /document #56

Open MFrank2 opened 3 months ago

MFrank2 commented 3 months ago

document_data: Change type to object

masv3971 commented 3 months ago

Please, provide an explanation why you think that.

MFrank2 commented 3 months ago

Perhaps I lack understanding here. The intention of the response of this endpoint is that the matadata and business data of the document are transferred to the issuer system in order to subsequently create and transfer the credential. As with all other endpoints, I assume that the Document_data is returned as an object, which is a structured JSON of the document content. Please give me an explanation why the data should be passed exceptionally as a string.

masv3971 commented 3 months ago

document_data is not a string, its an object in json and a map[string]any in golang. From swagger yaml; document_data: additionalProperties: {} type: object

hope this helps!

MFrank2 commented 3 months ago

Thank you, this is fine