search

dc4eu / vc

European Wallet
BSD 2-Clause "Simplified" License
0 stars 2 forks source link

Change Request regarding /revoke #57

Open MFrank2 opened 3 months ago

MFrank2 commented 3 months ago
  1. Rename to /status for clarification of its function - /revoke is misleading as revocation is done with the /document/revoke call prior to this function which is intended for storage of status information from the generic issuer towards the Data Store
  2. Delete document_id as identifier as revocation (id) may affect multiple documents and is therefore to be used ->include full revoke object as reason, reference etc. are relevant to be stored. TBD Revoked boolean shall be not included as this call shall only be able to set the boolean to false - no return to true desired per revocation definition
masv3971 commented 3 months ago
  1. What about /revocation/status or /document/status? than it's a bit more clear what the status refer to.
  2. I'm not sure what you mean, should document_id be removed? revocation.id has to be unique in order not to revoke more than one document. Why should "this call" only be able to set revocation.revoked to false? If it sets anything it should be true.