search

dc7290 / template-ejs-loader

ejs-loader with webpack5 support. Chain it to html-loader and use it with html-webpack-plugin.
MIT License
24 stars 3 forks source link

fix "Passing individual values" issue #15

Closed mizok closed 2 years ago

mizok commented 2 years ago

Hey man, I got another pull request for you, and I also helped fix your README, too. It is about the issue "Passing individual values", I found that the old method you mentioned in README using querystring is not working(seems to be something wrong with your entry path)

And since Node.js had marked the querystring as legacy API in version 14.x, and recommended using URLSearchParams, I think we should give the old method an upgrade .

I am still using webpack loader inline for this problem, but I change the old method for a little bit (You can check it).

If you have any problem, feel free to contact me using twitter : D

Cheers 👍

fix #11

dc7290 commented 2 years ago

@mizok

You've helped me again! Thank you for suggesting a new way to do the old way!

There are a few things I would like to see corrected, please.

mizok commented 2 years ago

Sure, I will change this ASAP.

mizok commented 2 years ago

BTW it is named htmlWebpackPluginTemplateCustomizerConfig, not WebpackPluggingTemplateCustomizerConfig, or are you more intended for this name (WebpackPluggingTemplateCustomizerConfig)?

I named this way bc I thought it is only for htmlWebpackPlugin, since this loader has that dependency.

mizok commented 2 years ago

ok~

dc7290 commented 2 years ago

BTW it is named htmlWebpackPluginTemplateCustomizerConfig, not WebpackPluggingTemplateCustomizerConfig, or are you intended for this name (WebpackPluggingTemplateCustomizerConfig)?

I named this way bc I thought it is only for htmlWebpackPlugin, since this loader has this dependency.

This is a mistake. You can leave it as it is now!

dc7290 commented 2 years ago

@mizok

Thanks! Now we have a way to pass individual values!