Closed mizok closed 2 years ago
@mizok
You've helped me again! Thank you for suggesting a new way to do the old way!
There are a few things I would like to see corrected, please.
Sure, I will change this ASAP.
BTW it is named htmlWebpackPluginTemplateCustomizerConfig
, not WebpackPluggingTemplateCustomizerConfig
, or are you more intended for this name (WebpackPluggingTemplateCustomizerConfig
)?
I named this way bc I thought it is only for htmlWebpackPlugin
, since this loader has that dependency.
ok~
BTW it is named
htmlWebpackPluginTemplateCustomizerConfig
, notWebpackPluggingTemplateCustomizerConfig
, or are you intended for this name (WebpackPluggingTemplateCustomizerConfig
)?I named this way bc I thought it is only for
htmlWebpackPlugin
, since this loader has this dependency.
This is a mistake. You can leave it as it is now!
@mizok
Thanks! Now we have a way to pass individual values!
Hey man, I got another pull request for you, and I also helped fix your README, too. It is about the issue "Passing individual values", I found that the old method you mentioned in README using
querystring
is not working(seems to be something wrong with your entry path)And since
Node.js
had marked thequerystring
as legacy API in version 14.x, and recommended usingURLSearchParams
, I think we should give the old method an upgrade .I am still using webpack loader inline for this problem, but I change the old method for a little bit (You can check it).
If you have any problem, feel free to contact me using twitter : D
Cheers 👍
fix #11