search

dcSpark / cardano-multiplatform-lib

Rust implementation of Cardano
MIT License
98 stars 36 forks source link

Support duplicate keys before Valentine #209

Closed SebastienGllmt closed 1 year ago

SebastienGllmt commented 1 year ago

The Valentine hardfork removed the ability to have duplicate keys in map types in Cardano (https://github.com/dcSpark/cddl-codegen/issues/38). Theoretically CML should support duplicate keys before Valentine (at least in key places where they actually occurred onchain on mainnet) to be fully compatible

rooooooooob commented 1 year ago

Do we know all the places we need to support? We need to in metadatum keys (or was it metadata labels?). Did we ever encounter it in plutus datums?

SebastienGllmt commented 1 year ago

I think right now in CML we have patches for duplicate keys in all the places we ran into it in practice, right?

SebastienGllmt commented 1 year ago

https://github.com/dcSpark/cardano-multiplatform-lib/pull/74