Open rooooooooob opened 7 months ago
When we retrieve blocks from oura/cardano-net-fetcher we get even these blocks with explicit era tags as if it were:
As a reminder, the Cardano network specification has a separate CDDL definition from the ledger specification and CML currently doesn't contain any codegen from the networking spec. I'm not sure the networking cddl is a particularly good state (I've never heard good things about it)
In Byron the era tag wrapping struct is explicitly a part of the CDDL:
For all the other eras there is no mention at all of this outer wrapping struct e.g. Conway (all other eras are similar):
When we retrieve blocks from oura/cardano-net-fetcher we get even these blocks with explicit era tags as if it were:
One approach in order to respect the CDDL it could make sense to keep the tag info in the byron blocks but not touch them in the other eras, and then in
MultiEraBlock
do the check as if it were defined like:or similar.
We currently have
MultiEraBlock::from_explicit_network_cbor_bytes()
to parse using this era tag struct.