search

dcSpark / cardano-multiplatform-lib

Rust implementation of Cardano
MIT License
98 stars 36 forks source link

wasm-bindgen: upgrade to 0.2.87 and remove serde-deserialize feature #335

Closed ecioppettini closed 4 months ago

ecioppettini commented 4 months ago

Removes the deprecated serde-serialize feature (which seems unused, but I'm not a 100% sure). Also upgrades the wasm-bindgen version. I'm actually not sure if the version pinning is needed for some reason, but this is the minimum version I needed to add this as a dependency in the milkomeda bridge.

hadelive commented 4 months ago

Why don't you bump to the latest version (0.2.92)? Btw, could you merge the PR and release new version, @rooooooooob? (We need it for this PR)

solidsnakedev commented 4 months ago

please upgrade to 0.2.92 we're currently having issues with the current CML version, https://github.com/Anastasia-Labs/lucid-evolution/issues/149

ecioppettini commented 4 months ago

Why don't you bump to the latest version (0.2.92)?

The main reason was that 0.2.87 is the version pinned by cardano-serialization-lib, so that enables using them together. I could change this to >=0.2.87 though.

solidsnakedev commented 4 months ago

Why don't you bump to the latest version (0.2.92)?

The main reason was that 0.2.87 is the version pinned by cardano-serialization-lib, so that enables using them together. I could change this to >=0.2.87 though.

yes, that makes sense