dcai / airnotifier

Push Notifications Server for Human Beings.
Other
593 stars 187 forks source link

[WIP] Cleaning unused tokens from APNS and GCM #180

Closed Raphcal closed 6 years ago

dcai commented 6 years ago

@Raphcal Thanks for contributing!

Phoenix09 commented 6 years ago

Clearly this wasn't tested in any way before being merged:

$ ./airnotifier.py
Traceback (most recent call last):
  File "./airnotifier.py", line 38, in <module>
    from pushservices.gcm import GCMClient
  File "/opt/airnotifier/pushservices/gcm.py", line 53, in <module>
    class GCMClient(PushService):
  File "/opt/airnotifier/pushservices/gcm.py", line 99, in GCMClient
    def send(self, regids, data=None, collapse_key=None, ttl=None, retries=5, appdb=appdb):
NameError: name 'appdb' is not defined

What's the point in Travis running make test when all that does is run true? It doesn't even attempt to run airnotifier, making using Travis completely pointless.

$ git log --oneline -S appdb
ad92fb5 Cleaning unused tokens from APNS and GCM
4777f9f Fix broadcast code #55

git checkout ad92fb5: same exception git checkout ad92fb5~1: works

Raphcal commented 6 years ago

@Phoenix09 Really sorry for this, the branch was still work in progress when it was merged. I'm fixing this ASAP

dcai commented 6 years ago

@Phoenix09 my apologies, I shouldn't merge it before merging it, I will find some time to implement proper testing for airnotifier.