search

dcaliste / maep-qt

A map viewer for Jolla Sailfish OS
29 stars 14 forks source link

Make compass reference frame switchable #25

Closed vmatare closed 7 years ago

vmatare commented 7 years ago

I find it impractical to have the compass point to the north pole. Instead I want it to show the device's orientation relative to the map I'm seeing. Since modes of orientation are diverse, I think it's best to support both options and let the user choose what works most intuitively for them.

vmatare commented 7 years ago

Thanks for the quick review. I implemented the requested changes in a separate commit, but I think I should meld them together with commit #f5d5956 before merging.

vmatare commented 7 years ago

Done. Let me know if you're satisfied and I'll squash.

vmatare commented 7 years ago

I think it may take some time before the pull request is updated to reflect the rebase. Btw, you might want to release a new build to the Jolla store since it fails with some unresolved symbols after the latest Sailfish upgrade.

Anyways, thanks a lot for maintaining this very efficient & functional tool. I'm using it all the time.

dcaliste commented 7 years ago

Btw, you might want to release a new build to the Jolla store since it fails with some unresolved symbols after the latest Sailfish upgrade.

I know, but the rpmvalidator in EA SDK complains about libraries while it was not the case before. I think it's a mistake in the new SDK and I've submitted a PR for this. I'm waiting for them to accept it. I'm afraid people in Harbour may reject the submission looking blindly at the result of rpmvalidator. Anyway, if they don't answer to the PR soon, I'll submit anyway with a comment !