search

dcantatore / react-rrule-builder-ts

rrule component for react with mui
MIT License
7 stars 2 forks source link

Typechecks for react-rrule-builder-ts are failing during yarn build #5

Closed elitsab closed 1 month ago

elitsab commented 1 month ago

Tried to push a fix to remove the 'clearable' attributes as they are not type defined but did not have permission to create a branch.

https://github.com/search?q=repo%3Adcantatore%2Freact-rrule-builder-ts%20clearable&type=code

Could you please remove them? Thank you!

dcantatore commented 1 month ago

Hi @elitsab -

I'm not sure what you mean. Are you saying - you would like start and end date clear functionality to be configurable? Other wise those slotProps are the correct types as they are.

also - you need to create a branch, then a pull request that is approved before it can merge into main

elitsab commented 1 month ago

I meant to say that 'clearable' property is not known/defined. Installing the package via yarn and doing a yarn build results in errors: image

elitsab commented 1 month ago

I got access denied when I attempted to push a branch earlier. image

dcantatore commented 1 month ago

I'm making a guide for contributing that should help, will be out soon.

For the error - have you installed the peer dependencies in your project? This package relies on you having them installed.

If so and it's still an issue can you post an example repo to reproduce the issue? Otherwise I haven't been able to reproduce it.

dcantatore commented 1 month ago

Here is the guide: https://github.com/dcantatore/react-rrule-builder-ts/blob/main/CONTRIBUTING.md

elitsab commented 1 month ago

Hi Dario!

I apologize I did not get the chance to respond earlier! The issue turned out to be with out setup on our side as you implied! We seem to have enforced tighter TypeScript rules on our end and for some reason the skipLibCheck compiler option for TypeScript did not work so it was emitting errors from the package. I tried to isolate the issue in a clean vite + React + Typescript app and am happy to share that I was unable to reproduce the issue.

We do appreciate the documentation on how to contribute back and the datetime adapters! We also added some additional logic to convert the rrule strings to cron for our background job Hangfire runners using this. Thank you for repo!

Any idea when you will mark your work as prod ready?