dcantrell / bsdutils

Alternative to GNU coreutils using software from FreeBSD
Other
171 stars 9 forks source link

meson.build: make fts check more robust #42

Closed andy5995 closed 1 year ago

andy5995 commented 1 year ago

I don't know if there was a reason you wanted to link statically, so maybe this change I'm proposing isn't exactly what you need.

Some recent discussion about this change in https://github.com/theimpossibleastronaut/rmw/pull/385

dcantrell commented 1 year ago

Making this detection more robust is welcome. If I recall correctly, find_library() was used because I think at the time dependency() was not working to pick up libfts on musl systems. But I could be wrong.

The static option is there simply because it is an option and someone may want to build static bsdutils. So this patch should continue to honor the setting of the fts_static option that the user can set. It defaults to false but the user can set it up true at build time to link statically with libfts.