search

dcantrell / pyparted

Python bindings for GNU parted (libparted)
GNU General Public License v2.0
85 stars 42 forks source link

3.12.0: pytest is failing in `tests/test__ped_disktype.py::DiskTypeStrTestCase::runTest` unit #94

Closed kloczek closed 1 year ago

kloczek commented 2 years ago

I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.

Here is pytest output:

```console + PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pyparted-3.12.0-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pyparted-3.12.0-2.fc35.x86_64/usr/lib/python3.8/site-packages + /usr/bin/pytest -ra =========================================================================== test session starts ============================================================================ platform linux -- Python 3.8.13, pytest-7.1.2, pluggy-1.0.0 rootdir: /home/tkloczko/rpmbuild/BUILD/pyparted-3.12.0 collected 273 items tests/test__ped_alignment.py ......... [ 3%] tests/test__ped_chsgeometry.py ... [ 4%] tests/test__ped_constraint.py ........ [ 7%] tests/test__ped_device.py .....s...ss............ss. [ 16%] tests/test__ped_disk.py ..sssss....s..........sssssssssss.. [ 29%] tests/test__ped_disktype.py ...F [ 31%] tests/test__ped_filesystem.py ... [ 32%] tests/test__ped_filesystemtype.py ... [ 33%] tests/test__ped_geometry.py .................. [ 39%] tests/test__ped_partition.py ............. [ 44%] tests/test__ped_ped.py ............s.............. [ 54%] tests/test_parted_alignment.py ..ssss..s [ 57%] tests/test_parted_constraint.py ..ssssss [ 60%] tests/test_parted_device.py sssssssssssssssss.ssss [ 68%] tests/test_parted_disk.py ssssssssss.ssssssss.......sssssssssss [ 82%] tests/test_parted_filesystem.py ssss [ 83%] tests/test_parted_geometry.py sssssss.sssss.ss [ 89%] tests/test_parted_parted.py .....ss.ss. [ 93%] tests/test_parted_partition.py .........sss.ssss [100%] ================================================================================= FAILURES ================================================================================= _______________________________________________________________________ DiskTypeStrTestCase.runTest ________________________________________________________________________ self = def runTest(self): > self.assertEqual(str(self.disktype['msdos']), '_ped.DiskType instance --\n name: msdos features: 1') E AssertionError: '_ped.DiskType instance --\n name: msdos features: 5' != '_ped.DiskType instance --\n name: msdos features: 1' E _ped.DiskType instance -- E - name: msdos features: 5? ^ E + name: msdos features: 1? ^ tests/test__ped_disktype.py:78: AssertionError ============================================================================= warnings summary ============================================================================= tests/test__ped_constraint.py::ConstraintDuplicateTestCase::runTest /home/tkloczko/rpmbuild/BUILD/pyparted-3.12.0/tests/test__ped_constraint.py:107: DeprecationWarning: use copy.deepcopy() to duplicate a _ped.Constraint self.dup = self.c.duplicate() -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ========================================================================= short test summary info ========================================================================== SKIPPED [1] tests/test__ped_device.py:102: Unimplemented test case. SKIPPED [1] tests/test__ped_device.py:153: Unimplemented test case. SKIPPED [1] tests/test__ped_device.py:159: Unimplemented test case. SKIPPED [1] tests/test__ped_device.py:356: Unimplemented test case. SKIPPED [1] tests/test__ped_device.py:362: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:43: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:49: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:55: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:61: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:67: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:89: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:155: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:161: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:167: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:173: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:179: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:185: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:191: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:197: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:203: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:209: Unimplemented test case. SKIPPED [1] tests/test__ped_disk.py:215: Unimplemented test case. SKIPPED [1] tests/test__ped_ped.py:205: Requires root SKIPPED [1] tests/test_parted_alignment.py:81: Unimplemented test case. SKIPPED [1] tests/test_parted_alignment.py:87: Unimplemented test case. SKIPPED [1] tests/test_parted_alignment.py:93: Unimplemented test case. SKIPPED [1] tests/test_parted_alignment.py:99: Unimplemented test case. SKIPPED [1] tests/test_parted_alignment.py:141: Unimplemented test case. SKIPPED [1] tests/test_parted_constraint.py:125: Unimplemented test case. SKIPPED [1] tests/test_parted_constraint.py:131: Unimplemented test case. SKIPPED [1] tests/test_parted_constraint.py:137: Unimplemented test case. SKIPPED [1] tests/test_parted_constraint.py:143: Unimplemented test case. SKIPPED [1] tests/test_parted_constraint.py:149: Unimplemented test case. SKIPPED [1] tests/test_parted_constraint.py:155: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:31: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:37: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:43: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:49: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:55: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:61: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:67: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:73: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:79: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:85: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:91: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:97: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:103: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:109: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:115: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:121: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:127: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:137: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:143: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:149: Unimplemented test case. SKIPPED [1] tests/test_parted_device.py:155: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:33: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:39: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:45: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:51: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:57: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:63: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:69: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:75: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:81: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:87: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:107: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:113: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:119: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:125: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:131: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:137: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:143: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:149: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:202: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:208: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:214: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:220: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:226: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:232: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:238: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:244: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:250: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:256: Unimplemented test case. SKIPPED [1] tests/test_parted_disk.py:262: Unimplemented test case. SKIPPED [1] tests/test_parted_filesystem.py:30: Unimplemented test case. SKIPPED [1] tests/test_parted_filesystem.py:36: Unimplemented test case. SKIPPED [1] tests/test_parted_filesystem.py:42: Unimplemented test case. SKIPPED [1] tests/test_parted_filesystem.py:48: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:33: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:39: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:45: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:51: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:57: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:63: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:69: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:83: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:89: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:95: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:101: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:107: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:124: Unimplemented test case. SKIPPED [1] tests/test_parted_geometry.py:130: Unimplemented test case. SKIPPED [1] tests/test_parted_parted.py:96: Unimplemented test case. SKIPPED [1] tests/test_parted_parted.py:102: Unimplemented test case. SKIPPED [1] tests/test_parted_parted.py:132: Unimplemented test case. SKIPPED [1] tests/test_parted_parted.py:138: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:224: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:230: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:236: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:255: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:261: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:267: Unimplemented test case. SKIPPED [1] tests/test_parted_partition.py:273: Unimplemented test case. FAILED tests/test__ped_disktype.py::DiskTypeStrTestCase::runTest - AssertionError: '_ped.DiskType instance --\n name: msdos features: 5' != '_ped.DiskType instance --\... ========================================================== 1 failed, 159 passed, 113 skipped, 1 warning in 0.76s =========================================================== ```
dcantrell commented 1 year ago

There are a number of Python 3.12 problems that I'm working on at the moment. Thanks for the report on this one.

cjwatson commented 1 year ago

This is a duplicate of #91, isn't it? Looks like it just needs a new release.

kloczek commented 1 year ago

I've tested release + all patches generated out of commits added after last version and test suite with those commis is not failing.

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pyparted-3.12.0-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pyparted-3.12.0-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra -m 'not network'
============================= test session starts ==============================
platform linux -- Python 3.8.17, pytest-7.3.2, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/pyparted-3.12.0
collected 280 items

tests/test__ped_alignment.py .........                                   [  3%]
tests/test__ped_chsgeometry.py ...                                       [  4%]
tests/test__ped_constraint.py ........                                   [  7%]
tests/test__ped_device.py .....s...ss............ss.                     [ 16%]
tests/test__ped_disk.py ..sssss....s..........sssssssssss..              [ 28%]
tests/test__ped_disktype.py ....                                         [ 30%]
tests/test__ped_filesystem.py ...                                        [ 31%]
tests/test__ped_filesystemtype.py ...                                    [ 32%]
tests/test__ped_geometry.py ..................                           [ 38%]
tests/test__ped_partition.py .................                           [ 45%]
tests/test__ped_ped.py ............s.............                        [ 54%]
tests/test_parted_alignment.py ..ssss..s                                 [ 57%]
tests/test_parted_constraint.py ..ssssss                                 [ 60%]
tests/test_parted_device.py sssssssssssssssss.ssss                       [ 68%]
tests/test_parted_disk.py ssssssssss.ssssssss.......sssssssssss          [ 81%]
tests/test_parted_filesystem.py ssss                                     [ 82%]
tests/test_parted_geometry.py sssssss.sssss.ss                           [ 88%]
tests/test_parted_parted.py .....ss.ss.                                  [ 92%]
tests/test_parted_partition.py .............sss.ssss                     [100%]

=========================== short test summary info ============================
SKIPPED [1] tests/test__ped_device.py:104: Unimplemented test case.
SKIPPED [1] tests/test__ped_device.py:159: Unimplemented test case.
SKIPPED [1] tests/test__ped_device.py:166: Unimplemented test case.
SKIPPED [1] tests/test__ped_device.py:554: Unimplemented test case.
SKIPPED [1] tests/test__ped_device.py:561: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:29: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:36: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:43: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:50: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:57: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:84: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:161: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:168: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:175: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:182: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:189: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:196: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:203: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:210: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:217: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:224: Unimplemented test case.
SKIPPED [1] tests/test__ped_disk.py:231: Unimplemented test case.
SKIPPED [1] tests/test__ped_ped.py:248: Requires root
SKIPPED [1] tests/test_parted_alignment.py:70: Unimplemented test case.
SKIPPED [1] tests/test_parted_alignment.py:77: Unimplemented test case.
SKIPPED [1] tests/test_parted_alignment.py:84: Unimplemented test case.
SKIPPED [1] tests/test_parted_alignment.py:91: Unimplemented test case.
SKIPPED [1] tests/test_parted_alignment.py:137: Unimplemented test case.
SKIPPED [1] tests/test_parted_constraint.py:129: Unimplemented test case.
SKIPPED [1] tests/test_parted_constraint.py:136: Unimplemented test case.
SKIPPED [1] tests/test_parted_constraint.py:143: Unimplemented test case.
SKIPPED [1] tests/test_parted_constraint.py:150: Unimplemented test case.
SKIPPED [1] tests/test_parted_constraint.py:157: Unimplemented test case.
SKIPPED [1] tests/test_parted_constraint.py:164: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:16: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:23: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:30: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:37: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:44: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:51: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:58: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:65: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:72: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:79: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:86: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:93: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:100: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:107: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:114: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:121: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:128: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:140: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:147: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:154: Unimplemented test case.
SKIPPED [1] tests/test_parted_device.py:161: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:18: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:25: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:32: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:39: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:46: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:53: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:60: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:67: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:74: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:81: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:104: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:111: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:118: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:125: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:132: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:139: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:146: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:153: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:215: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:222: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:229: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:236: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:243: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:250: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:257: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:264: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:271: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:278: Unimplemented test case.
SKIPPED [1] tests/test_parted_disk.py:285: Unimplemented test case.
SKIPPED [1] tests/test_parted_filesystem.py:15: Unimplemented test case.
SKIPPED [1] tests/test_parted_filesystem.py:22: Unimplemented test case.
SKIPPED [1] tests/test_parted_filesystem.py:29: Unimplemented test case.
SKIPPED [1] tests/test_parted_filesystem.py:36: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:18: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:25: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:32: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:39: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:46: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:53: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:60: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:76: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:83: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:90: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:97: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:104: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:127: Unimplemented test case.
SKIPPED [1] tests/test_parted_geometry.py:134: Unimplemented test case.
SKIPPED [1] tests/test_parted_parted.py:90: Unimplemented test case.
SKIPPED [1] tests/test_parted_parted.py:97: Unimplemented test case.
SKIPPED [1] tests/test_parted_parted.py:129: Unimplemented test case.
SKIPPED [1] tests/test_parted_parted.py:136: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:328: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:335: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:342: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:363: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:370: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:377: Unimplemented test case.
SKIPPED [1] tests/test_parted_partition.py:384: Unimplemented test case.
======================= 167 passed, 113 skipped in 0.80s =======================
dcantrell commented 1 year ago

This is a duplicate of #91, isn't it? Looks like it just needs a new release.

There are two issues. Yes, #91 is fixed in git and I need to cut a new release. But right now there are problems with the test suite and Python 3.12 which I am sorting out.

dcantrell commented 1 year ago

pyparted-3.13.0 has been released which works on Python 3.11.x and 3.12.x now.