search

dcantrell / pyparted

Python bindings for GNU parted (libparted)
GNU General Public License v2.0
86 stars 43 forks source link

Add new disk types - disk uuid and partition uuid #96

Closed bcl closed 1 year ago

bcl commented 2 years ago

libparted now supports retrieving the disk and partition uuid values, this adds support for the disk type flags, and fixes up the tests to include them.

bcl commented 2 years ago

This is incomplete, needs to add support for new functions too, and needs the new parted version which isn't yet available.

berrange commented 2 years ago

Can you point to the upstream parted change mentioned - I'm not finding it in my git master for parted. The partition UUID value in particular is something I was also looking for when doing the changes in #95, as that's needed to support the systemd bootloader spec requirements for /var partitions.

bcl commented 2 years ago

It hasn't been pushed to master yet, here's a github PR with the change - https://github.com/bcl/parted/pull/12

There's nothing there that should be triggering the FPE crash, but I'm hitting it consistently enough in my testing that I don't currently trust anything :)

dcantrell commented 2 years ago

So far it looks reasonable. When you are ready for this one, request me as the reviewer.

bcl commented 1 year ago

This depends on #100 now, and I added the new no_automount flag to it as well as fixing a missing test on the PARTITION_LINUX_HOME flag. This should be applied after #100.