dcapslock / weewx-responsive-skin

Weewx Responsive Skin using the Bootstrap framework
22 stars 9 forks source link

question about removing white space around pictures and implementing all time history.... #11

Closed peters77 closed 4 years ago

peters77 commented 4 years ago

Hi,

I use your weewx Responsive skin and modified it to my needs. Thanks for sharing it, the skin is very nice and I'm verry happy. :-)

Could you give me a hint howto remove the white space around all the pictures and content in a panel-body? Bildschirmfoto 2020-07-07 um 19 01 41

Thanks in advance.

I found this in the google weewx user really group https://groups.google.com/forum/#!topic/weewx-user/Dfl7_i0trGI and it would be great if you could implement the historygenerator in your the Responsive skin too like Richard G did here https://github.com/gedger/alltimeSeasons.

Would be great. My site with your adapted skin: https://wetter.hcpeters.de/

Regards,

Christian

dcapslock commented 4 years ago

Hi Peter,

Glad you like the skin.

To remove the padding you need to overwrite the default bootstrap .panel-body CSS padding of 15px.

Regarding the history generator, I am not a fan of putting HTML into a Weewx generator. It should be in the template so its easily changed. So while I could implement the history generator, I don’t agree with its method. However as it stands you could include the generator php, then either add a panel to the main page below the graphs OR create a new page using the main page as a template, and replaced the graphs with the history generator tags.

If I get some time I may have a look. However at the moment I will not have time before the end of July.

Regards

Darryn Capes-Davis

From: peters77 notifications@github.com Sent: Wednesday, 8 July 2020 3:12 AM To: dcapslock/weewx-responsive-skin weewx-responsive-skin@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [dcapslock/weewx-responsive-skin] question about removing white space around pictures and implementing all time history.... (#11)

Hi,

I use your weewx Responsive skin and modified it to my needs. Thanks for sharing it, the skin is very nice and I'm verry happy. :-)

Could you give me a hint howto remove the white space around all the pictures and content in a panel-body? [Bildschirmfoto 2020-07-07 um 19 01 41]https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F8840918%2F86816995-c6b22080-c084-11ea-89a0-b7b0a01007b1.png&data=02%7C01%7C%7Ce7041d991ea8465368c408d82298cd90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637297386959657204&sdata=7uHbauT6QEXkVFiJeFjc%2BIDvQIA0e4hqTWu267KkTRU%3D&reserved=0

Thanks in advance.

I found this in the google weewx user really group https://groups.google.com/forum/#!topic/weewx-user/Dfl7_i0trGIhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fforum%2F%23!topic%2Fweewx-user%2FDfl7_i0trGI&data=02%7C01%7C%7Ce7041d991ea8465368c408d82298cd90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637297386959667200&sdata=QVixnqRFZm8uLsqnNHUf3Qkl3K4kKTOpqfsIjSjlYD4%3D&reserved=0 and it would be great if you could implement the historygenerator in your the Responsive skin too like Richard G did here https://github.com/gedger/alltimeSeasonshttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgedger%2FalltimeSeasons&data=02%7C01%7C%7Ce7041d991ea8465368c408d82298cd90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637297386959677196&sdata=ZIJIKv3CG7JidEL4BRe2%2F%2FaSlLdm%2FM%2B7hiDnTtP8UA8%3D&reserved=0.

Would be great. My site with your adapted skin: https://wetter.hcpeters.de/https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwetter.hcpeters.de%2F&data=02%7C01%7C%7Ce7041d991ea8465368c408d82298cd90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637297386959687192&sdata=928kVbsUz57%2F0g6M0OznQA8oY20hdxdJiDhyRHVsXhQ%3D&reserved=0

Regards,

Christian

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdcapslock%2Fweewx-responsive-skin%2Fissues%2F11&data=02%7C01%7C%7Ce7041d991ea8465368c408d82298cd90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637297386959697189&sdata=H4VMYN01sFKf%2F28F2bIW8UlWwuISTJtXqFrq6g48Ivo%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADLXZBXBWRQBXVDQXBSND3DR2NJMJANCNFSM4OTCJHTA&data=02%7C01%7C%7Ce7041d991ea8465368c408d82298cd90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637297386959707182&sdata=aLaA0LVaJ1XxwFkM7kRdLjgQVj9%2FC3dtn3j6XU7KnAw%3D&reserved=0.

peters77 commented 4 years ago

Hi Darryn,

thank you for the hint. I'm not very skilled regading programming but with the help of google I figured out how to change the padding:

<style>
#mypanelId{
     padding: 2px;
}
</style>

and

<div class="panel-body" id="mypanelId">

did the trick for me.

Yes, maybe it's not the best solution regarding putting html in a generator. Maybe you will have some fun to implement it somtimes or add your own way to implement such an useful overview. I'll try to add the php somehow to your skin...

Regards,

Christian