search

dcaputo-harmoni / open-balena-admin

Open Balena Admin
MIT License
90 stars 18 forks source link

The README is not up to date regarding the instruction #4 #25

Open Razzorback225 opened 9 months ago

Razzorback225 commented 9 months ago

In the following instruction on the ReadMe :

image

The minimum parameters to include in the quickstart command is not correct as the user is supposed to add also the 'S3_ACCESS_KEY' and 'S3_SECRET_KEY' as asked by the following condition in the quickstart script (line 54 to 57):

if [ -z "${VERSION}" ] || [ -z "${JWT_SECRET}" ]|| [ -z "${S3_ACCESS_KEY}" ]|| [ -z "${S3_SECRET_KEY}" ]; then usage exit 1 fi

The helper is also not up to date.

alexszilagyi commented 9 months ago

@Razzorback225 have you managed to make it work?

Razzorback225 commented 8 months ago

@alexszilagyi Yeap, I after I added the 2 missing parameters I got it to work. But otherwise the quickstart script does not do anything without them.

dcaputo-harmoni commented 8 months ago

@Razzorback225 would you mind submitting a PR with the change that fixed the issue?

Razzorback225 commented 8 months ago

@dcaputo-harmoni Sure !

tchey290 commented 7 months ago

@alexszilagyi Yeap, I after I added the 2 missing parameters I got it to work. But otherwise the quickstart script does not do anything without them.

@Razzorback225 Hey what steps did you take to get this to work? I am able to run the quickstart-helm after adding the missing parameters and then when I try helm install I am getting the error below

helm install openbalena-admin ./helm -f ./helm/values.yaml

Error: INSTALLATION FAILED: template: openbalena-admin/templates/services/ui.yaml:10:20: executing "openbalena-admin/templates/services/ui.yaml" at <.Values.ui.s ervice.labels>: nil pointer evaluating interface {}.labels

If you have a step by step guide that would be awesome. I'm still learning helm and kubernetes.