dcarral / atom-ruby-test-switcher

Atom package to switch between Ruby source code and test files
https://atom.io/packages/ruby-test-switcher
MIT License
13 stars 1 forks source link

Creation of test file #8

Open michaelbaudino opened 8 years ago

michaelbaudino commented 8 years ago

Hi there,

First, thanks a lot for your work on this life-changer plugin :sparkles:

I'm not sure if this is a bug report or a feature request, but when I try to switch from a file to its test file, but that the test file does not exist yet, nothing happens. I'd expect the test file to be created like in RailsGoToSpec, or at least a warning message saying that it does not exist.

Is that expected? If not, I'd vote for the creation of the test file :smiley:

dcarral commented 8 years ago

Hey @michaelbaudino, I'm glad you enjoy using the package, you're welcome!

It's a feature request (meaning current behavior is expected behavior), but the non-invasive asking approach (which, by the way, could be even configurable) sounds good enough to be implemented.

I'll try to work on something soon and ping you to discuss the expected behavior. Sounds good to you? ;)

michaelbaudino commented 8 years ago

Sure, thanks a lot :tophat:

dcarral commented 8 years ago

Heads-up to @michaelbaudino @teohm: I've just implemented it in the create-test-file-if-none-found branch. A new configuration setting is exposed, as documented in the README:

The following configuration settings are exposed:

  • Create test file if none is found (default: false).

    If enabled, a new text editor is opened when switching to inexistent test files. If disabled, no text editors are opened.

Would you like to check it out and let me know how it serves your use cases?

Anyway, since I'm not happy with the current limitations on the target path, as explained in the commit description, I'd like to get rid of them before merging this into master.

Generalizing the package (by exposing several configuration settings with sensible defaults) is something I needed to do anyway, so expect the follow-ups to come soon.

sadhu89 commented 7 years ago

I have installed the package with apm develop ruby-test-switcher and did checkout to the branch...but I can not see the new configuration option.

dcarral commented 7 years ago

Closing stale issues.

pomartel commented 7 years ago

I was also looking for a similar feature. Is the branch still active? Any reason why it won't be merged to master?

dcarral commented 7 years ago

First of all, sorry for the great delay getting back @pomartel.

Second, it's always great to hear from people using the package ;)

Regarding the feature itself:

This thread unfortunately became stale after not hearing back from @michaelbaudino, let's reopen it.... it's definitely a useful setting.

Have you by any chance successfully used the branch since then? It's accessible and the concerns regarding target path limitation should still apply.

michaelbaudino commented 7 years ago

Hi, sorry for not speaking out earlier, but the awful truth is I have no idea how to run an Atom package from a development branch 😖

I still use your package on a daily basis though, so thank you a thousand times for your work 🙇 💯 🎩

dcarral commented 7 years ago

@michaelbaudino @sadhu89 This should do the trick:

git clone git@github.com:dcarral/atom-ruby-test-switcher.git
cd atom-ruby-test-switcher
git checkout create-test-file-if-none-found
apm install
apm link .
atom