search

dcarrith / queuel

Extending Laravel's Queue Functionality
5 stars 2 forks source link

Question regarding stability #1

Open maknz opened 10 years ago

maknz commented 10 years ago

Hi there,

Thanks for improving the SQS implementation for Laravel. It's a shame the PRs for the core were rejected, they were very nice enhancements.

Just wondering how far away you think this is from a stable release (if you plan on releasing it)? Would very much like to use the releasing functionality and building the Queue URL automatically (rather than pushing to a hardcoded SQS URL, and listening on the connection name :S).

dcarrith commented 10 years ago

Hi @maknz - Sorry for the delayed response. I just got back from a 10 day vacation and didn't see this before I left. This project is still very new and still under heavy development (usually only on the weekends). That being said, the SQS and RabbitMQ enhancements/additions have been fairly well tested and each have unit tests that are currently all passing. I'll try to solidify an initial release of the "queuel" package within a week or two and let you know when it's ready.

maknz commented 10 years ago

Cool, thanks for the response. I've moved onto using Beanstalkd in the meanwhile, so don't rush for me.

DaHaiz commented 8 years ago

hi dcarrith,

i totally agree with maknz, your improvements should have been definitely merged into the core. I'm currently developing an application with elastic beanstalk and need the sqs push queue functionality. Can you tell me if your package is still working with laravel 5.0/5.1? As far as i can tell from your previous posts it seems it works pretty stable, doesnt it?

thanks, simon

spawn-guy commented 8 years ago

Hello Again :) I still remember this package, and this time i got some work-time to, actually, use it.

@DaHaiz the library looks straight-forward. so i can bet it will hold the production use.

i'll post my findings on what can be improved here:

1) Packagist registration would be nice. /me just tried to add it to Pkgst. it didn't allow me to. as @dcarrith has one package already and we should kindly ask the Author to submit it. so for now this needs to be added to composer.json

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/dcarrith/queuel.git"
        }
    ],
spawn-guy commented 8 years ago

next. according to https://github.com/laravel/framework/blob/5.1/composer.json mockery shouldn't be "dev-master" but "mockery/mockery": "~0.9.2", also it should be in "require-dev" i'll try if it works and create a pull-req

dcarrith commented 8 years ago

@DaHaiz @spawn-guy - I think things have changed pretty drastically with packages in Laravel 5. So, the work that I (and others) did on this for Laravel 4.x is not likely to work. I do intend to revisit it, but haven't had the time lately.

spawn-guy commented 8 years ago

damn, @dcarrith , i just made a pull-req ;) ... it now, at least, installs it.

looking further in. i think i will start testing tomorrow if it works at all.

UPD: i don't think it should be a problem to make it work on L5.. i think queue part wasn't touched at all. but i don't keep my hand on pulse there.