search

dcasia / nova-filepond

A Nova field for uploading File, Image and Video using Filepond.
MIT License
48 stars 27 forks source link

Doka included? #7

Closed rikschennink closed 4 years ago

rikschennink commented 4 years ago

Awesome you created this package! 🙌

I'm not a 100% sure but from the readme it's unclear if Doka is included in the package. Maybe it's a good idea to make it more explicit that this is a commercial product and that the developer should purchase a license and has to manually add the required files.

milewski commented 4 years ago

I'm not a 100% sure but from the readme it's unclear if Doka is included in the package.

Surely it's not included 😆

But yeah reading the doc again I have assumed that description of js_path/css_path would be enough to figure that out that they should include the required files ... but didn't realize people might not know its a paid plugin 

doka' => [
    'enabled' => true,
    'js_path' => public_path('doka.min.js'), // this assumes you places theses files within your public directory
    'css_path' => public_path('doka.min.css'),
]

If you could update that readme with some official wording of your product that would be awesome

rikschennink commented 4 years ago

@milewski I suspected it wasn't but still thanks for confirming :D

I'll see if I can add some words to the readme. 👍

rikschennink commented 4 years ago

Done!

milewski commented 4 years ago

Thanks! merged!