dcaslin / d2-checklist

Source for www.d2checklist.com, written in Angular and using the Bungie API
https://www.d2checklist.com/
MIT License
91 stars 24 forks source link

Add an additional "compare panel" for for armor that share element and season mod slot. #146

Closed rafigalb closed 4 years ago

rafigalb commented 4 years ago

Similar to when you have multiple copies and you can click the panel to easily compare them, It would be neat to add another button to compare all armor that share element and (maybe optional) seasonal mod slot.

This would be absolutely killer for the way I manage my vault. I typically keep 1-3 items of each slot/element/season mod with varying stat spread, and this would make it a breeze to compare and quickly mark keep/junk.

rafigalb commented 4 years ago

This is kind of what I had in mind.

VE6BkdF6iI

dcaslin commented 4 years ago

So, in your example, compare by element would include all legendary Arc Titan Arms, right? And by season would be all legendary Arc Titan arms for Season of Undying?

rafigalb commented 4 years ago

Exactly!

dcaslin commented 4 years ago

Try it now, I added an extra icon below the "Copies" button to show similar items. For armor it's by bucket and burn, for weapons it's by type and frame. Had to tweak the compare dialog a bit to make it work (like showing the names of disparate items in that case) but it wasn't too tough.

This was a great idea! Let me know if you have any other suggestions for it, if not I'll close out this issue and announce it (trying to decide if i should bother exposing this on mobile).

rafigalb commented 4 years ago

Omg already? You are fast bro.

And yes, this is great! The only comments I can think of at the moment:

Really awesome job, can’t wait to tag a bunch of stuff when I get home. (On mobile now but I remoted into my PC to see changes)

rafigalb commented 4 years ago

Also I wasn’t even thinking about weapons but it’s also gonna be super useful to compare the same frames, good job!

dcaslin commented 4 years ago
rafigalb commented 4 years ago

Another thing I noticed, Exotics show up when comparing legendary. Maybe also match the item quality?

dcaslin commented 4 years ago

TODO

rafigalb commented 4 years ago

To clarify just in case, my main use would be to compare armor with similar burn AND seasonal mod. So for example if I compare a legendary Titan helmet that is solar and dawn mod, all legendary Titan helmets with solar and dawn mod would show up.

dcaslin commented 4 years ago

Phew... ok latest version is pushed with sorting and most of those other issues solved. Let me know how you feel on the seasons filtering w/ burn vs not. Easy enough to toggle, I'm going to go sort my gear tonight and get a feel for it myself.

dcaslin commented 4 years ago

And... the prod build doesn't work, hold please...

dcaslin commented 4 years ago

And... we're back. Font awesome's latest library breaks prod builds, but only after you load them, which isn't cool.

rafigalb commented 4 years ago

Haven’t had a chance to play with it yet. But from the screenshots you just tweeted it’s perfect! You are awesome!

dcaslin commented 4 years ago

Todo: fix default sort on the compare dialog (shows sorted by LL but isn't actually). Ideally use the sort from the main screen by default OR remember last dialog sort

rafigalb commented 4 years ago

Ok I think when comparing with seasonal mods it would be more useful to only show same burn, at least for the way I manage my gear.

So the options would be:

rafigalb commented 4 years ago

Hell, thinking about it it would be even better if you kept the 3 you already have and add a 4th one with same burn and season mod. That would be ideal IMO.

So basically:

rafigalb commented 4 years ago

Sweet! I see that you added it, but at the moment "season" and "season & burn" show the same items. Its not filtering for same burn, just season.

dcaslin commented 4 years ago

Oops... Ok try it now (also moved around some of the buttons and made "Compare" more obvious to click)

rafigalb commented 4 years ago

So far everything looks perfect. Excellent job!