dcaslin / d2-checklist

Source for www.d2checklist.com, written in Angular and using the Bungie API
https://www.d2checklist.com/
MIT License
91 stars 24 forks source link

About FontAwesome PRO, "OriginHeaderDoesNotMatchKey" POST Error, Internationalization #360

Closed eTiTan closed 3 years ago

eTiTan commented 3 years ago

I'm working on the code, trying to raise a server, i find some of challenges:

Propostals:

I want to discuss here for all because should be a short responses, i think that "OK", "THANKS", "NICE" maybe all the responses.

Regards.

dcaslin commented 3 years ago

Hi. Are you running at "https://localhost:4200" in dev mode? That's what you need to have the test D2Checklist api key match the origin header.

eTiTan commented 3 years ago

Yeah, i'm running "https://localhost:4200" at dev mode, i think that this is not a priority, i'm focus on replace the Font awesome pro icons, giving others chance to contribute too, and implement the internationalisation too.

i have a question, i want to known your opiinion, because i thinking how to do about the gliph that should to change (talking about Font Awesome Pro removal), i find that you are using a custon font set for some of gliph, i think that is a good idea.

Wath should be the "right" practice on this case?

Use a custom set (i can move/export/create) the needed gliph or use other font set like iconofy...

I need your opinion about it.

Regards.

dcaslin commented 3 years ago

I'm pretty heavily invested in FontAwesome Pro at this point. Not really looking to change it.