search

dcaslin / d2-checklist

Source for www.d2checklist.com, written in Angular and using the Bungie API
https://www.d2checklist.com/
MIT License
92 stars 24 forks source link

Guilded challenges should not count towards seal completion #535

Closed ScriptedBot closed 1 year ago

ScriptedBot commented 1 year ago

Currently, triumph challenges that are part of guilding a seal are getting considered as progression towards the seal completion. This is causing the seal to show as completed if a player has enough completions from the guilded challenges section to compensate for the deficit in attaining challenges required for actual seal completion. For example, if a player has seal progression of 15/16 for the Star Baker seal, and if they have completed one of the additional guilded challenges, then the UI shows the triumph as attained with 16/16 which is incorrect - the numerator is correct, but the status of the seal is not.

dcaslin commented 1 year ago

Good call! Will fix in next push

image