search

dcavins / hierarchical-groups-for-bp

Adds hierarchical group functionality to your BuddyPress-powered community site.
25 stars 9 forks source link

Missing argument 2 for HGBP_Public::make_permalink_hierarchical() in class-hgbp.php #2

Closed HiveMindNet closed 7 years ago

HiveMindNet commented 7 years ago

Not sure what else to say and plugin seems to be functioning fine but seeing apache error log entries as above/stating "Missing argument 2 for HGBP_Public::make_permalink_hierarchical() in </DIR/TREE/>class-hgbp.php"

dcavins commented 7 years ago

Thanks for testing things out, and for the update.

That's a weird notice you're getting. It makes me think that somewhere, bp_get_group_permalink(), or a function that uses it, is being used outside of a bp_has_groups() loop. If it's easy to do, can you check for places that that function is being used in your plugins folder? Look especially for times when it's called without passing a group object to it.

Thanks!

HiveMindNet commented 7 years ago

Hi,

I don't know if this help - but I'm running a boss theme (a child), in addition to the Kleo theme (only on 1 page - the front - which uses the k-elements plugin) and buddy boss' global search plugin which we've modified / improved a little.

This is what a grep shows...

bash-3.2# grep 'bp_get_group_permalink()' -R * bp-group-organizer/includes/group-organizer.php: <?php printf( __( 'Link: %s', 'bp-group-organizer' ), '' . esc_html( stripslashes( $item->name ) ) . '' ); ?> buddyboss-media/includes/types/photo-hooks.php: $group_link = sprintf( "%s", bp_get_group_permalink(), bp_get_group_name() ); buddypress/bp-templates/bp-legacy/buddypress/groups/single/cover-image-header.php: buddypress/bp-templates/bp-legacy/buddypress/groups/single/cover-image-header.php: buddypress/bp-templates/bp-legacy/buddypress/groups/single/group-header.php: buddypress-global-search/templates/loop/group-ajax.php: k-elements/shortcodes/templates/buddypress/kleo_bp_groups_carousel.php: $output .= ''; k-elements/shortcodes/templates/buddypress/kleo_bp_groups_grid.php: $output .= ''; bash-3.2#

dcavins commented 7 years ago

OK, I think we can rule out buddypress/bp-templates/bp-legacy/buddypress/groups/single/cover-image-header.php
buddypress/bp-templates/bp-legacy/buddypress/groups/single/cover-image-header.php

Are the group links in the Kleo widgets correct? What about the results set of the global search? And the BuddyBoss Media photo links? If you find a group link that is broken, we've found the problem.

HiveMindNet commented 7 years ago

So maybe I was too quick to highlight this as a problem... As my setup is less than ideal and frankly there's no visible problem except a php warning in the logs. I'm running 2 themes and one of them (Kleo) isn't even exposed to buddypress (it's only for a font page) and that's caused a number of issued already elsewhere. Add to this that every link and feature of your plugin is working... If I get a chance I'll try disabling Kleo on my localhost and see if that still throws a warning. Otherwise, I'd suggest parking this until I can actually see something sensible wrong (sorry about that - it was late last night when testing).

dcavins commented 7 years ago

Hi @HiveMindNet-

No problem! Please let me know what you ultimately find out.

Thanks!

-David

HiveMindNet commented 7 years ago

David - I wonder if you could possibly help with a quick question. I’ve been using your plugin since we last emailed with good results. However I also use the plugin buddypress-group-email-options for email digests. When posting a new update, the links work well in the email sent. However for some reason, all links in the digest for comments (as in replies to posts) the links seem broken and don’t land where they should. I was curious if this was due to hierachy issues. For example, I just received an email with a link to a comment which is

https://thehive.hivemindnetwork.com/activity/p//#acomment-9614 however it should have been

https://thehive.hivemindnetwork.com/activity/p/9491/#acomment-9614

The links also look this way in the ‘preview’ so I know it’s not getting broken in the email/email creation.

I appreciate that this may be nothing to do with the group hierarchy but I wanted to ask as it may look like something obvious to you.

Thanks,

Lyndon

On Sat, 10 Dec 2016 at 18:28 David Cavins notifications@github.com wrote:

Hi @HiveMindNet-

No problem! Please let me know what you ultimately find out.

Thanks!

-David

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dcavins/hierarchical-groups-for-bp/issues/2#issuecomment-266227759, or mute the thread https://github.com/notifications/unsubscribe-auth/ASc1JVcf7D29XHf5AScaNTsfwBQpe8ufks5rGu9hgaJpZM4LIc_H .

-- Lyndon Docherty Founding Partner & Chief Executive http://www.hivemindnetwork.com/ http://thehive.me/lyndon https://www.linkedin.com/profile/view?id=3972605 https://plus.google.com/+Hivemindnetwork/posts https://twitter.com/HiveMindNet Effective Business; Better Days E: lyndon@hivemindnetwork.com | W: thehive.me/lyndon L: www.linkedin.com/profile/view?id=3972605 https://www.linkedin.com/profile/view?id=3972605 | Tw: @HiveMindNet https://twitter.com/HiveMindNet

dcavins commented 7 years ago

Hi @HiveMindNet-

Please test making a comment without HGBP activated. I'm seeing the same problem you are, but HGBP doesn't affect it. There were some changes to the activity stream in BP 2.7, it could be that BPGES is not up-to-date with all changes.

HiveMindNet commented 7 years ago

OK - if you’re seeing the same as me, any chance you could let me know if/how you sort it and I’ll do the same it I get it sorted first?

Cheers

On Sun, 18 Dec 2016 at 15:41 David Cavins notifications@github.com wrote:

Hi @HiveMindNet-

Please test making a comment without HGBP activated. I'm seeing the same problem you are, but HGBP doesn't affect it. There were some changes to the activity stream in BP 2.7, it could be that BPGES is not up-to-date with all changes.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dcavins/hierarchical-groups-for-bp/issues/2#issuecomment-267828206, or mute the thread https://github.com/notifications/unsubscribe-auth/ASc1JeMyiSbWhfkgY11TOFqDsLggohtJks5rJVQ4gaJpZM4LIc_H .

-- Lyndon Docherty Founding Partner & Chief Executive http://www.hivemindnetwork.com/ http://thehive.me/lyndon https://www.linkedin.com/profile/view?id=3972605 https://plus.google.com/+Hivemindnetwork/posts https://twitter.com/HiveMindNet Effective Business; Better Days E: lyndon@hivemindnetwork.com | W: thehive.me/lyndon L: www.linkedin.com/profile/view?id=3972605 https://www.linkedin.com/profile/view?id=3972605 | Tw: @HiveMindNet https://twitter.com/HiveMindNet

HiveMindNet commented 7 years ago

David - here’s the fix :)

https://github.com/boonebgorges/buddypress-group-email-subscription/commit/b0167ab721c15f93c2a777633caeb6089bd6b245

On Sun, 18 Dec 2016 at 15:41 David Cavins notifications@github.com wrote:

Hi @HiveMindNet-

Please test making a comment without HGBP activated. I'm seeing the same problem you are, but HGBP doesn't affect it. There were some changes to the activity stream in BP 2.7, it could be that BPGES is not up-to-date with all changes.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dcavins/hierarchical-groups-for-bp/issues/2#issuecomment-267828206, or mute the thread https://github.com/notifications/unsubscribe-auth/ASc1JeMyiSbWhfkgY11TOFqDsLggohtJks5rJVQ4gaJpZM4LIc_H .

-- Lyndon Docherty Founding Partner & Chief Executive http://www.hivemindnetwork.com/ http://thehive.me/lyndon https://www.linkedin.com/profile/view?id=3972605 https://plus.google.com/+Hivemindnetwork/posts https://twitter.com/HiveMindNet Effective Business; Better Days E: lyndon@hivemindnetwork.com | W: thehive.me/lyndon L: www.linkedin.com/profile/view?id=3972605 https://www.linkedin.com/profile/view?id=3972605 | Tw: @HiveMindNet https://twitter.com/HiveMindNet

dcavins commented 7 years ago

Leave it to @r-a-y to know the answer.

dcavins commented 7 years ago

@HiveMindNet I tracked down one cause the warning"Missing argument 2 for HGBP_Public::make_permalink_hierarchical() in </DIR/TREE/>class-hgbp.php": BP Group Email Subscription calls the bp_get_group_permalink filter using the pre-BP2.5 signature, which doesn't send the second argument. You can fix it in the short term by changing two lines in BPGES: https://github.com/boonebgorges/buddypress-group-email-subscription/commit/32698f0b3bda51e1d3f7e981ff176cb6b91e79cb

There are probably others, but I know you're using BPGES, so I'll bet that change will fix your issue. :)

dcavins commented 7 years ago

@cezarneaga's PR here: https://github.com/dcavins/hierarchical-groups-for-bp/commit/48d9b68a008c86696db5a9479af63a019843c471 should solve this issue. Thanks to everyone who helped out with diagnosing and fixing the problem!

cezarneaga commented 7 years ago

are you putting this plugin up on wordpress.org? i am sure we could add a notice on current plugin to redirect here

dcavins commented 7 years ago

I'm planning to submit this to wordpresss.org once a few more details are worked out. (For instance, the settings form is OK on single-site installations but fails on network installations.) I'm pretty close to being ready, though. Thanks!