search

dcbaker / meson-plus-plus

An experimental and incomplete implementation of Meson in C++, for solving Meson's bootstrapping issue.
Apache License 2.0
50 stars 7 forks source link

1 #107

Closed neheb closed 2 years ago

dcbaker commented 2 years ago

Sorry for the conflicts, but all your work with clang-tidy got me thinking we should probably check clang-tidy in CI so no one (me) doesn't reintroduce any of these issues. So, I've added a job to CI, and updated the .clang-tidy file with the checks you've fixed (plus i fixed some others). Could you add any checks that are completely fixed to the clang-tidy file so we can keep them fixed?

neheb commented 2 years ago

One concern is that clang-tidy also checks files that are in .gitignore. I've avoided touching those on purpose.

dcbaker commented 2 years ago

Yeah, I've noticed that clang-tidy sometimes checks things it shouldn't, and I'm not sure how to fix that (it's check test cases, for example). I might have to change the job to run on the src dir and not run with meson

neheb commented 2 years ago

Rebased.