dcbaker / meson-plus-plus

An experimental and incomplete implementation of Meson in C++, for solving Meson's bootstrapping issue.
Apache License 2.0
45 stars 7 forks source link

Restructure function lowering so that it doesn't check the name of the function over and over #87

Closed dcbaker closed 2 years ago

dcbaker commented 2 years ago

Currently, the function lowering code is written such that each lowering function checks the name and holder of the FunctionCall object, as well as whether all of the arguments are lowered. This is just not ideal, we should do that check once, and then dispatch to the correct lowering code if necessary. This avoids having to do the same checks over and over, and should yield a performance improvement.