@usmcamp0811 I have some questions about this PR that you submitted
here you set self.external_kernel to true in both cases, and then you gate the "running" status update behind not self.external_kernelhere. This just completely disables the running status functionality.
I'm assuming that in this case if ".json" not in self.kernel_name: it's supposed to set external kernel to false, and that line is just a typo. But I'm also wondering why the status updates needed to be disabled with external kernels at all?
I'll note for completeness that this also removes magma's ability to shut down a running kernel on deinit. as seen here
69 broke the "running" status
@usmcamp0811 I have some questions about this PR that you submitted
here you set
self.external_kernelto true in both cases, and then you gate the "running" status update behindnot self.external_kernelhere. This just completely disables the running status functionality.I'm assuming that in this case
if ".json" not in self.kernel_name:it's supposed to set external kernel to false, and that line is just a typo. But I'm also wondering why the status updates needed to be disabled with external kernels at all?I'll note for completeness that this also removes magma's ability to shut down a running kernel on deinit. as seen here