dccsillag / magma-nvim

Interact with Jupyter from NeoVim.
GNU General Public License v3.0
977 stars 49 forks source link

[Feature Request] Handling Html Objects #119

Open MinaMatta98 opened 10 months ago

MinaMatta98 commented 10 months ago

Is your feature request related to a problem? Please describe. Hello,

I have output that results in a html file. Look below:

image

Describe the solution you'd like I think it would be rather wonderful if you could implement a html view via redirecting to browser.

benlubas commented 8 months ago

@MinaMatta98 would you want this to open automatically when a cell finishes running? Or with a new command?

I'm thinking about adding this to https://github.com/benlubas/molten-nvim, and I'm curious about how you would want this to work.

Personally I think I'd like this to be a separate command. But I'm willing to implement both if you or others would rather have this work automatically.

MinaMatta98 commented 8 months ago

Hello,

I generally expect this to open after the finalization of the run.

However, you are the repo maintainer and you should implement this in a manner that you deem necessary.

benlubas commented 8 months ago

Cool. I'll put the auto open behind a configuration variable then.

At the end of the day I'm trying to make the best thing for people to use, so I like to collect feedback on how others will use this plugin.

MinaMatta98 commented 8 months ago

Thank you kind sir.

On Tue, 12 Dec 2023, 3:09 pm Ben Lubas, @.***> wrote:

Cool. I'll put the auto open behind a configuration variable then.

At the end of the day I'm trying to make the best thing for people to use, so I like to collect feedback on how others will use this plugin.

— Reply to this email directly, view it on GitHub https://github.com/dccsillag/magma-nvim/issues/119#issuecomment-1851268027, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATPWGTEAO6BS6A74UMNMRD3YI7KHRAVCNFSM6AAAAAA6H7763KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRGI3DQMBSG4 . You are receiving this because you were mentioned.Message ID: @.***>

benlubas commented 8 months ago

@MinaMatta98 this is merged into main. It's not part of a release yet. I have to test a few things before I cut a new release. It'll be released in a few days probably.

If you want to use it right away you can just use the main branch of molten instead of a release.

benlubas commented 8 months ago

It's now released at well in 1.2.0