search

dccsillag / magma-nvim

Interact with Jupyter from NeoVim.
GNU General Public License v3.0
988 stars 50 forks source link

Add MagmaEnterOutput #33

Closed tzachar closed 2 years ago

tzachar commented 2 years ago

Allow users to enter the output window Also decorate the window with borders

tzachar commented 2 years ago

Hi @dccsillag Any chance of merging this? Have been using it for the past 2 weeks and found it very useful.

dccsillag commented 2 years ago

Sorry for the delay; Yeah, I will be merging this; I just haven't done so because I want to check carefully if everything is fine with the window borders you've enabled, and have been quite busy with other things.

I'll try to check things out and merge in the next few days.

tzachar commented 2 years ago

@dccsillag ping

dccsillag commented 2 years ago

Hey, sorry for the massive delay. I'm going to tackle this now. I'll cherry pick the window borders out of this PR, and reimplement them with a configuration toggle (I'll still mention you in the commit(s)).

dccsillag commented 2 years ago

All done with edf60f0b809c88dab3a4ea492e0dcf80fc00af5b.

tzachar commented 2 years ago

10x

WhiteBlackGoose commented 1 year ago

Hi, thanks for this, but for some reason it won't switch to the window for me:

pynvim.api.common.NvimError: Vim:E5555: API call: Failed to switch to window 1011

I suspect it's because it closes the window and then tries to switch. Any idea how to fix it?

WhiteBlackGoose commented 1 year ago

FWIW, since likely no one will respond, I made a workaround for it by copying the traceback into clipboard automatically

my fork