Install script still refers to "master" branch

[wjdhamilton]

Describe the bug When attempting to install using vim-plug the following error occurs:

fatal: invalid reference: master

To Reproduce Steps to reproduce the behavior:

Install the plugin per the instructions for vim-plug, i.e.:

Plug 'dccsillag/magma-nvim', { 'do': ':UpdateRemotePlugins' }

Expected behavior Vim-plug confirms the plugin installed properly

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: MacOS 12.5
• Browser: N/A

[dccsillag]

There isn't an install script; :UpdateRemotePlugins is just a NeoVim command to register remote plugins (which this is one of).

So, as it is, there actually isn't anything referring to the master branch specifically there. In fact:

magma-nvim  main [~u] $ rg master
magma-nvim  main [~u] ✗ 1 $

That is, there is no mention of the master branch anywhere in this repo.

I remember experiencing similar issues with vim-plug, though (but with other plugins) -- I don't know why it happens. My workaround was to add a , branch: 'main' to the options table:

Plug 'dccsillag/magma-nvim', { 'do': ':UpdateRemotePlugins', 'branch': 'main' }

[wjdhamilton]

Ah! Thank you very much, that fixed it.

Many thanks,

James Hamilton

On 10 Aug 2022, at 13:10, Daniel Csillag @.**@.>> wrote:

There isn't an install script; :UpdateRemotePlugins is just a NeoVim command to register remote plugins.

So, as it is, there actually isn't anything referring to the master branch specifically there. In fact:

magma-nvim  main [~u] $ rg master magma-nvim  main [~u] ✗ 1 $

That is, there is no mention of the master branch anywhere in this repo.

I remember experiencing similar issues with vim-plug, though (but with other plugins) -- I don't know why it happens. My workaround was to add a , branch: 'main' to the options table:

Plug 'dccsillag/magma-nvim', { 'do': ':UpdateRemotePlugins', 'branch': 'main' }

— Reply to this email directly, view it on GitHubhttps://github.com/dccsillag/magma-nvim/issues/47#issuecomment-1210585291, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZHAKXJHHW3ICDZELYRFIDVYOL4ZANCNFSM56EFXF4Q. You are receiving this because you authored the thread.Message ID: @.***>

[wjdhamilton]

Just looking at that again…what does the “master” in “ magma-nvim  main [~u] $ rg master” refer to?

Many thanks,

James

On 10 Aug 2022, at 20:38, Daniel Csillag @.***> wrote:



Closed #47https://github.com/dccsillag/magma-nvim/issues/47 as completed.

— Reply to this email directly, view it on GitHubhttps://github.com/dccsillag/magma-nvim/issues/47#event-7166700589, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZHAKT43L32D3ETFLXJ2KLVYQAJXANCNFSM56EFXF4Q. You are receiving this because you authored the thread.Message ID: @.***>

[dccsillag]

The magma-nvim  main [~u] $ is my shell's prompt: magma-nvim is the directory name,  main indicates that I'm on branch main, [~u] indicates that there are unstaged files (u) and modified files (~) (and my git diff does not touch anything mentioning any branches, just some internal logic), and $ is a prompt character separator.

Then, the command rg master uses ripgrep; think of it as grep -r master . but that ignores things in the gitignore & .git, and is overall faster (there are more differences, but that's the gist of it here; it's quite practical). It doesn't give any output, which indicates that there is no file in the repository where the pattern master can be found.

[wjdhamilton]

I see! Sorry for being thick :-).

Many thanks,

James Hamilton

On 11 Aug 2022, at 11:35, Daniel Csillag @.**@.>> wrote:

The magma-nvim  main [~u] $ is my shell's prompt: magma-nvim is the directory name,  main indicates that I'm on branch main, [~u] indicates that there are unstaged files (u) and modified files (~) (and my git diff does not touch anything mentioning any branches, just some internal logic), and $ is a prompt character separator.

Then, the command rg master uses ripgrephttps://github.com/BurntSushi/ripgrep; think of it as grep -r master . but that ignores things in the gitignore, and is overall faster (there are more differences, but that's the gist of it here; it's quite practical). It doesn't give any output, which indicates that there is no file in the repository where the pattern master can be found.

— Reply to this email directly, view it on GitHubhttps://github.com/dccsillag/magma-nvim/issues/47#issuecomment-1211814851, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZHAKQJ7LVXYV4WYGQD3EDVYTJP5ANCNFSM56EFXF4Q. You are receiving this because you authored the thread.Message ID: @.***>

[dccsillag]

Ah, no worries! Glad to have helped.