fix issue with rpchost defined in bitcoin.conf not being used

dcdpr / btcr-DID-method

BTCR is the reference Decentralized Identifier (DID) method for the Bitcoin blockchain

BSD 3-Clause "New" or "Revised" License

7 stars 5 forks source link

fix issue with rpchost defined in bitcoin.conf not being used #28

Closed hawkmauk closed 5 years ago

hawkmauk commented 5 years ago

fix for #27

hawkmauk commented 5 years ago

Was able to test the following:

Test	Result
~/.bitcoin/bitcoin.conf present with rpchost defined	rpchost from bitcoin.conf used
~/.bitcoin/bitcoin.conf present with rpchost, --rpchost added to command line	rpchost from command line used
~/.bitcoin/bitcoin.conf not present with --rpchost on command line	rpchost from command line used
~/.bitcoin/bitcoin.conf not present no --rpchost on command line	default host 127.0.0.1 used

danpape commented 5 years ago

Thanks for looking at this @hawkmauk. I can't quite recall the reason I was using setCommandOption instead of setOption... I thought there must have been one. I will dig into this before you and I chat tomorrow.