Open sylvainfaivre opened 1 year ago
I started porting salt-lsp to pygls 1.0+ (see https://github.com/dcermak/salt-lsp/pull/285), but sadly never managed to finish that work. Unfortunately this project is more or less unmaintained. It was a hackweek project from two years ago and only really reached an early prototype stage. We never managed to implement a satisfactory behavior when Jinja2 templating was involved in the salt yaml files (and I doubt there's a straightforward way to pull it off :-/ ), which was a bit of a death sentence. We haven't really touched this project since.
I have not archived the project to keep it open for potential new maintainers, but I personally don't have the time to work on this anymore.
I would be more than happy for any contributions, but as I said, my time to help out is really limited.
OK, sorry I won't be able to help, I'm more of a sysadmin than a developer. It might be a good idea to add a paragraph into the README.md with what you replied here, more people would be able to see it.
sylvainfaivre @.***> writes:
OK, sorry I won't be able to help, I'm more of a sysadmin than a developer. It might be a good idea to add a paragraph into the README.md with what you replied here, more people would be able to see it.
No worries. I've created https://github.com/dcermak/salt-lsp/pull/363 to address your suggestion.
great, thanks !
I have a branch in my fork: https://github.com/ekacnet/salt-lsp/tree/dev It upgrades pygls to 1.1 and also allows to parse sls files with jinja in it.
I am trying to run salt-lsp with Python 3.11, which is shipped with Ubuntu 23.04.
I first updated the dependancies by running
poetry update
beforepoetry install
.I then ran
poetry run dump_state_name_completions
which run successfully.But the server failed with the following error :
This seems related to https://github.com/pydantic/pydantic/issues/4500 which is fixed in pydantic v1.10.3 - see https://github.com/pydantic/pydantic/issues/4552
So I tried to add
pydantic = ">=1.10.3"
in the[tool.poetry.dependencies]
section inpyproject.toml
Then
poetry update
:The next step was to replace
pygls = "^0.11.3"
withpygls = ">=0.11.3"
I redid the whole steps, then I got another error at runtime :
This seems related to a breaking change in pygls v1.0 : https://pygls.readthedocs.io/en/latest/pages/migrating-to-v1.html