search

dcf21 / star-charter

A command-line tool for producing vector-graphics charts of the night sky in SVG, PDF and PNG formats.
GNU General Public License v3.0
338 stars 29 forks source link

Error: Could not open Tycho ASCII catalogue #7

Open talafeco opened 3 years ago

talafeco commented 3 years ago

I downloaded the package, installed the dependencies, also downloaded the new versions of empty star database (ftp://cdsarc.u-strasbg.fr/pub/cats/I/239/hip_main.dat). The catalogue merge script exits:

(...) Warning: moving mag 10.4 star TYC 4640-232-1 by 0.010 deg (tycho1 --> tycho2) Warning: moving mag 7.5 star TYC 2521-2279-1 by 0.012 deg (hipparcos --> tycho2) ./setup.sh: 57. sor: 23683 Kilőve ./catalogue_merge.py Compiling code make: Nothing to be done for 'all'.

I see the following error during the program run using sample data:

mint20@mint20-virtual-machine:~/Letöltések/star-charter-master/examples$ ../bin/starchart.bin orion.sch Error: Fatal Error encounted in src/astroGraphics/stars.c at line 87: Error: Could not open Tycho ASCII catalogue

Please advise, thank you!

ycwang-hello commented 2 years ago

Hi, I encountered the same problem just now. I think the script catalogue_merge.py is killed by the system because it uses too much memory. Maybe someone could improve the code by avoiding keeping each star in the memory (I think the huge dictionary star_data defined on line 180 may consume most of the memory). I will try to run this on a machine with a larger memory. :)

BTMeeks commented 2 years ago

I confirmed on my 4G linux machine that catalog_merge.py was killed by the out of memory killer. I did some hacking to reject stars if their magnitude was greater than X (8 in my test), and was able to get past this and get star-charter to work. ( I haven't got star-charter to compile on MacOS Mojave yet.)

BTMeeks commented 2 years ago

I've done further testing with magnitude limits. With 4G of RAM on Linux, I'm able to merge the catalogs if I include mag 11 and brighter in under 3 minutes. If I try to go to mag 12, it doesn't finish after waiting a few hours.