dcfemtech / hackforgood-waba-map

DCFemTech Hack for Good 2016 - WABA Bike Map Project
MIT License
10 stars 9 forks source link

Design addition: credit and contact line #106

Open WABA-Comms opened 7 years ago

WABA-Comms commented 7 years ago

PROPS!

Trusting your design eye and design decisions for a sleek, simple, consistent look. Please add, "This map was built by incredible volunteers from DCFemTech (link) and Code For DC (link). The bike data (link to data matrix) was pulled from the respective DOTs on September 1st, 2016. Send bike infrastructure questions to advocacy@waba.org. ”

Color: Your call Size: You do you Position: the best place

hareno44 commented 7 years ago

I need a link to the data matrix, but otherwise the task is completed.

alulsh commented 7 years ago

@hareno44 - can you add a screenshot of the credit & contact line from your WIP branch to this GitHub issue? This will help us review your work.

hareno44 commented 7 years ago

image

<div id="description> <!-- map description code here -->

<p>This map was built by incredible volunteers from <a href="https://dcfemtech.github.io/">DCFemTech</a> and <a href= "http://codefordc.org/">Code For DC</a>.The bike data (link to data matrix) was <br>pulled from the respective DOTs on September 1st, 2016.Send bike infrastructure questions to advocacy@waba.org.</p> </div>

alulsh commented 7 years ago

@hareno44 - looks like you copied and pasted code from the branch instead of linking to the branch. For example, if I paste https://github.com/dcfemtech/hackforgood-waba-map/pull/127 into a GitHub issue comment it will turn into https://github.com/dcfemtech/hackforgood-waba-map/pull/127, a smart reference link to your pull request.

The menu + text in the header look a lot bigger in this screenshot than in other ones - did you zoom in in your browser or did you change the CSS of the text so it was larger?

hareno44 commented 7 years ago

@alulsh Thanks for the tip! Oh, I just zoomed in on the one part, though afterwards I think I'd just keep it to the regular, full page.