search

dcfemtech / hackforgood-waba-map

DCFemTech Hack for Good 2016 - WABA Bike Map Project
MIT License
10 stars 9 forks source link

Added code comments #60

Closed NealHumphrey closed 8 years ago

NealHumphrey commented 8 years ago

Added code comments to the Javascript file to better guide a new contributor on how the code works and on the syntax expected by the Mapbox SDK

alulsh commented 8 years ago

Normally I'm against a lot of code comments (I try as hard as I can to write easy to read code that doesn't need comments), but if it helps people more easily contribute to this project then I'm for it.

Thanks for launching this PR @NealHumphrey! I added some line notes - once those are tackled I can take another 👀 .

NealHumphrey commented 8 years ago

@alulsh I'll make those edits as you suggested and update the branch. I understand the code comment concern, but being just OK at Javascript and not knowing Mapbox at all this was everything I wished I had to understand it the first time!

NealHumphrey commented 8 years ago

@alulsh should be all set with those fixes now.

alulsh commented 8 years ago

This looks great @NealHumphrey! Tested locally and the buffers are back to blue. Going to merge.