search

dcfemtech / hackforgood-waba-map

DCFemTech Hack for Good 2016 - WABA Bike Map Project
MIT License
10 stars 9 forks source link

first draft civic file #64

Closed tomBeach closed 8 years ago

tomBeach commented 8 years ago

First version of civic.json file

alulsh commented 8 years ago

Thanks for taking a stab at this @tomBeach. I added some line notes for minor things. Once those are tackled I can merge this.

alulsh commented 8 years ago

@tomBeach - any update on this? This is good work and I'd love to merge it soon! If not, I'm happy to tackle the line comments myself as well.

alulsh commented 8 years ago

Whoops this is now saying it's from an unknown repository - I'm going to use the trick in https://speakerdeck.com/holman/more-git-and-github-secrets?slide=114 to fetch this and push as a feature branch to this repo so we can merge.

tomBeach commented 8 years ago

Sortof forgot about this PR but have now pushed a modified version of this civic.json file with the changes mentioned on new branch civicjson

alulsh commented 8 years ago

@tomBeach - I did a compare for your new civicjson branch in https://github.com/dcfemtech/hackforgood-waba-map/compare/civicjson.

Looks like this includes the new Mapbox GL JS commits from @hrecht's WIP branch in https://github.com/dcfemtech/hackforgood-waba-map/pull/97.

Mind creating a new branch that doesn't have the Mapbox GL JS changes and only modifies the civic.json file? This will make your civic.json branch considerably easier to merge. We will likely need to modify @hrecht's code in her PR - it's a Work In Progress (WIP).

alulsh commented 8 years ago

Closing in favor of https://github.com/dcfemtech/hackforgood-waba-map/pull/128.